This repository has been archived by the owner on Jul 14, 2024. It is now read-only.
Extract data from attached documents #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er as it is going to work with more formats than just PDF
Code quality scoreNice work!! The code quality has improved for this PR! ✨ 🌈 🎉 🌟
|
…eds to have its text extracted
…ed from a document
…_harvester into rm/extract-data-from-documents
…ed to be extracted from a file
Remove need for checking if the file is a binary when writing it to the filesystem.
eoin-boost
reviewed
Mar 7, 2024
| @@ -3,6 +3,10 @@ default: &default | |||
| SJ_USER_AGENT: Supplejack Harvester v2.0 | |||
| FIXTURES_PATH: spec/fixtures | |||
| OTP_ENCRYPTION_KEY: AGoodEncryptionKey | |||
| SECRET_KEY_BASE: anawesomelysecretsecretkeybase | |||
There was a problem hiding this comment.
It's just an example for people to use as a template when they set up the application :). A lot of our applications do this.
eoin-boost
approved these changes
Mar 7, 2024
motizuki
approved these changes
Mar 7, 2024
…vest definition templates
… when the extraction is still running
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an API user I want to see missing data collected from attached documents so that I have a more complete record to build against
Acceptance criteria