Feature: Indefinite duration Boombox #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedger
changed the title
amrro
reviewed
Feb 14, 2022
| } | ||
| import { | ||
| stackAggregationCommit, | ||
| poxAllowContractCaller, |
There was a problem hiding this comment.
I tried to run clarinet test insdide boombox-admin package and I got this error.
TS2305 [ERROR]: Module '"file:///Users/amrro/Developer/boom/boom-contracts/packages/boombox-admin/tests/client/boombox-admin.ts"' has no exported member 'poxAllowContractCaller'.
poxAllowContractCaller,
~~~~~~~~~~~~~~~~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the boombox-admin protocol to support indefinite duration and any cycle to join
extend-boomboxingSuggested naming:
classic Boombox: members can only join at a given cycle and for 1 locking period
indefinite Boombox: members can join at any cycle and continue after the first locking period
one-shot Boombox: members can join at any cycle, but only for 1 locking period
long Boombox: members can only join at a given cycle and continue after the first locking period