Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with horizontal resizing of table headers #835

Closed
ssunday opened this issue Nov 1, 2024 · 3 comments
Closed

Regression with horizontal resizing of table headers #835

ssunday opened this issue Nov 1, 2024 · 3 comments

Comments

@ssunday
Copy link

ssunday commented Nov 1, 2024

Overview of the problem

#827 seems to have created a regression when using this component to horizontally resize columns in a table—when you click the resize-enabled boundary between the headers (like the border if you have it visibly differentiated), it doesn't resize from the point you are clicking, but of the next column and opposite to how you are dragging.

Like if I grab the right side of a table header and drag it to the right, you expect that the header grows to the right. With this issue, the NEXT column actually shrinks and then going left increases the size of the next column, rather than changing the size of the column I am clicking on.

I'm guessing the issue is that the goal of that ordering conflicts with a table header resize use case. Maybe we make it optional or a prop or something? The issue does not exist in the previous version hence why I'm connecting it to #827 .

I'm using re-resizable 6.10.0

My browser is: Safari/Chrome I believe

I am sure this issue is not a duplicate? Yes

@felixhabib
Copy link

I've encountered a similar issue with #827. The change puts the topLeft, top, topRight and left resizable handles before the children in the DOM (ref). Depending on the layout used, this can cause the handles to be stacked below the children, preventing them from being selected.

To get the previous functionality, we had to provide an explicit zIndex for these handles - seek-oss/playroom#374.
Perhaps these need to be provided a higher zIndex than the children in this library?

@bokuweb
Copy link
Owner

bokuweb commented Nov 6, 2024

Sorry I'll revert it for now.
#836

@t-hamano Sorry I'll revert PR for now, because we ran into some regressions. I'll reconsider about focus order later.

@bokuweb
Copy link
Owner

bokuweb commented Nov 6, 2024

@ssunday @felixhabib v6.10.1 published 🙏

@bokuweb bokuweb closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants