Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Instant::epoch_milliseconds for values before Epoch #221

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix Instant::epoch_milliseconds for values before Epoch #221

merged 2 commits into from
Feb 28, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 28, 2025

Fix epoch_milliseconds not using div_euclid and add a unit test.

@nekevss nekevss added the C-internal Internal library improvements label Feb 28, 2025
@jedel1043 jedel1043 force-pushed the fix-epoch-milliseconds branch from 2c1dbd0 to e2083d5 Compare February 28, 2025 04:52
@jedel1043 jedel1043 added the C-bug Something isn't working label Feb 28, 2025
@jedel1043 jedel1043 merged commit 5b93f5e into main Feb 28, 2025
8 checks passed
@jedel1043 jedel1043 deleted the fix-epoch-milliseconds branch February 28, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
C-bug Something isn't working C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekevss @jedel1043