Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out remaining method stubs for temporal #4172

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Build out remaining method stubs for temporal #4172

merged 2 commits into from
Feb 23, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 22, 2025

This Pull Request is related to ongoing work for #1804

It changes the following:

  • Bumps temporal_rs version
  • Adds stubs for all remaining methods except for Duration.prototype.compare, PlainDate.prototype.toZonedDateTime (these methods are)

The main goal here was to complete some of the remaining leg work for Temporal in Boa (outside of any remaining debugging).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,324 46,451 +127
Ignored 1,634 1,634 0
Failed 2,296 2,169 -127
Panics 0 0 0
Conformance 92.18% 92.43% +0.25%
Fixed tests (128): 
test/intl402/Temporal/PlainYearMonth/prototype/until/mixed-calendar-invalid.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/since/mixed-calendar-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/disambiguation-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/toPlainDate/branding.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-with-utc-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/disambiguation-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/offset-property-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/invalid-offset.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/invalid-disambiguation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/offset-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/with/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/arguments-missing-throws.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-number.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/options-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/arguments-missing-throws.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/length.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/name.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/builtin.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/toPlainDate/branding.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-timezone-field.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-calendar-field.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/length.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/name.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/builtin.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/toPlainDate/branding.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/length.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/name.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/builtin.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/branding.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-missing.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/branding.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-string-zoneddatetime-wrong-offset.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-invalid-offset-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-wrong-type.js (previously Failed)
Broken tests (1): 
test/built-ins/Temporal/ZonedDateTime/prototype/with/object-must-contain-at-least-one-property.js (previously Passed)

@nekevss nekevss requested a review from a team February 22, 2025 01:50
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Feb 22, 2025
@nekevss
Copy link
Member Author

nekevss commented Feb 22, 2025

In regard to the tests, most of the legitimate passing tests should be related to branding, length, or options validation. Overall, it may not be best to put too much stock into them as the potential for false positives here is high since these are stubs.

With any luck though, there should be a decent chunk of passing tests.

jedel1043
jedel1043 approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hopefully a nice chunk of the tests are true positives.

@jedel1043 jedel1043 added this to the next-release milestone Feb 22, 2025
@nekevss
Copy link
Member Author

nekevss commented Feb 22, 2025

Hopefully a nice chunk of the tests are true positives.

Exactly my hope, but I just don't want to put too much weight into them 😆

@nekevss nekevss requested a review from a team February 22, 2025 02:02
@raskad raskad added this pull request to the merge queue Feb 23, 2025
Merged via the queue into main with commit f9ac2d6 Feb 23, 2025
14 checks passed
@raskad raskad deleted the temporal-unimplemented-stubs branch February 23, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @raskad @jedel1043