core/vote: not vote if too late for next in turn validator #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
not_vote_too_late
branch
from
d8b3f06 to
a12d80d
Compare
NathanBSC
changed the title
NathanBSC
force-pushed
the
not_vote_too_late
branch
from
a12d80d to
4088e4e
Compare
|
this may encourage validators to delay broadcast block? |
melissamforbs
approved these changes
Jul 9, 2024
IMO, not. |
zzzckck
reviewed
Jul 10, 2024
buddh0
force-pushed
the
not_vote_too_late
branch
from
4088e4e to
8c0d391
Compare
zzzckck
reviewed
Jul 10, 2024
zzzckck
reviewed
Jul 10, 2024
zzzckck
approved these changes
Jul 10, 2024
unclezoro
approved these changes
Jul 11, 2024
This was referenced Jul 17, 2024
Merged
jingjunLi
added a commit
to jingjunLi/bsc
that referenced
this pull request
Jul 22, 2024
…nb-chain#2568)" This reverts commit c96fab0.
jingjunLi
added a commit
to jingjunLi/bsc
that referenced
this pull request
Jul 22, 2024
…dator (bnb-chain#2568)"" This reverts commit fc31c54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core/vote: not vote if too late for next in turn validator
Rationale
Assume that at block height N, validator Va mines a large block BN, broadcasts it, and votes immediately. Due to the block's large size, other validators (such as Vb, Vc, and Vd) take a longer time to import BN, resulting in Vc and Vd voting for BN later. As a result, at block height N+1, Vb fails to collect enough votes for BN and mines and broadcasts a block BN1 without vote proof. Subsequently, backup validator Vc collects enough votes for BN, mines, and broadcasts a block BN1' with vote proof, causing other validators to experience a block reorganization (reorg).
this PR suggest not to vote if too late for next in turn validator
Example
add an example CLI or API response...
Changes
Notable changes: