cmd: fix dump cli cannot work in path mode #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
force-pushed
the
fix-dumppathdb
branch
15 times, most recently
from
52b7b42 to
268e195
Compare
sysvm
changed the title
sysvm
changed the title
fynnss
force-pushed
the
fix-dumppathdb
branch
from
268e195 to
30b7ef3
Compare
sysvm
force-pushed
the
fix-dumppathdb
branch
2 times, most recently
from
22aac42 to
c75e2e0
Compare
will-2012
reviewed
Jan 24, 2024
joeylichang
previously approved these changes
Jan 24, 2024
will-2012
reviewed
Jan 24, 2024
sysvm
force-pushed
the
fix-dumppathdb
branch
17 times, most recently
from
d5b8024 to
c0a47cd
Compare
|
The title of the PR is misleading. Please check. |
sysvm
changed the title
fixed |
sysvm
changed the title
This was referenced Feb 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr provides a fix for #2157. According to issue, users cannot dump state data in path mode. After debugging, there are some errors in state dump process.
BSC doesn't use
preimages, soDumpToCollectorusesgetTriecannot find trie in path mode. Hash mode only uses hash to retrieve node info. Therefore, usetrie.NewStateTriecreate a MPT trie in path mode.In addtiton, add
geth dump-roothashto help dump state in path mode.Rationale
Users can dump state data in path mode which locates in diffLayer, diskLayer or diskLayer nodebuffer(128+1).
Add
geth dump-roothashcommand to dump all available state root hash in path mode. Next, users can usegeth dumpto get what you like.Example
./geth dump-roothash --datadir ./data/ --state.scheme path./geth dump --datadir ./data --incompletes --db.engine=pebble --state.scheme path 481968Changes
Notable changes: