Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments: add comments to clarify flags and byte codes #1245

Merged
merged 2 commits into from
Dec 22, 2022
Merged

comments: add comments to clarify flags and byte codes #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f723c68
comments: add comments to clarify flags and byte codes
forcodedancing Dec 19, 2022
aa04736
comments: add comments to clarify flags and byte codes
forcodedancing Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/systemcontracts/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ var (
)

func init() {

// For contract upgrades, the following information is from `bsc-genesis-contract`, to be specifically,
// 1) `CommitUrl` is the specific git commit, based on which the byte code is compiled from;
// 2) `Code` is the byte code of the contract, which is generated by compiling `bsc-genesis-contract`.
// You can refer to `https://github.com/bnb-chain/bsc-genesis-contract` to compile the smart contracts and do the verification.

ramanujanUpgrade[rialtoNet] = &Upgrade{
UpgradeName: "ramanujan",
Configs: []*UpgradeConfig{
Expand Down
11 changes: 9 additions & 2 deletions eth/ethconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,15 @@ type Config struct {
Genesis *core.Genesis `toml:",omitempty"`

// Protocol options
NetworkId uint64 // Network ID to use for selecting peers to connect to
SyncMode downloader.SyncMode
NetworkId uint64 // Network ID to use for selecting peers to connect to
SyncMode downloader.SyncMode

// DisablePeerTxBroadcast is an optional config and disabled by default, and usually you do not need it.
// When this flag is enabled, you are requesting remote peers to stop broadcasting new transactions to you, and
// it does not mean that your node will stop broadcasting transactions to remote peers.
// If your node does care about new mempool transactions (e.g., running rpc services without the need of mempool
// transactions) or is continuously under high pressure (e.g., mempool is always full), then you can consider
// to turn it on.
DisablePeerTxBroadcast bool

// This can be set to list of enrtree:// URLs which will be queried for
Expand Down