Support local deployment #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mister-EA
requested review from
NathanBSC,
j75689,
brilliant-lx,
MatusKysel,
emailtovamos,
bnb-tw and
bnb-alexlucaci
buddh0
reviewed
Aug 24, 2023
|
maybe we need delete bscChaindId in file package.json |
buddh0
approved these changes
Aug 24, 2023
MatusKysel
reviewed
Aug 24, 2023
Comment on lines
+4
to
+15
| address: "0x37B8516a0F88E65D677229b402ec6C1e0E333004", | ||
| balance: web3.utils.toBN("500000000000000000000").toString("hex") // 500e18 | ||
| }, | ||
| { | ||
| address: "0x6c468CF8c9879006E22EC4029696E005C2319C9D", | ||
| balance: web3.utils.toBN("500000000000000000000").toString("hex") // 500e18 | ||
| }, | ||
|
|
||
| { | ||
| address: "0x04d63aBCd2b9b1baa327f2Dda0f873F197ccd186", | ||
| balance: web3.utils.toBN("500000000000000000000000000").toString("hex") // 500000000e18 | ||
| }, |
There was a problem hiding this comment.
do we have private keys available for those accounts? or how we can access those funds?
There was a problem hiding this comment.
Not sure, they were already there in the template. You can add your own addresses to the list via the template, and manage the keys yourself.
MatusKysel
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR facilitates the generation of the genesis contracts for a local deployment of a BSC network.
The node-deploy repository currently modifies the genesis contract templates using
sedwhich is prone to error and not easy to maintain due to overwriting the original files, but with this PR the genesis configurations for a local network can be generated simply by including the flag--network local.Motivation
To run a local network several additional steps need to be coordinated to enable recently added features: e.g. initializing the whitelisted relayers, enabling the finality reward, enabling malicious vote slashing etc. These steps are normally performed through standard transactions or through governance, but the flows may be complicated especially in a local environment.
To facilitate these steps, the initialization is done in the contract code itself when generating the bytecode for the genesis contracts. This PR ensures that these initializations happen automatically when passing the
--network localflag. (i.e.node generate-genesis.js --network local.Additional improvements
bscChainIdvalue from thechainidflag.node generate-initHolders.js --initHolders <commaSeparatedAddresses>