-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP-5: Token Resources [IMPROVEMENT] #5
Conversation
Initial commit
} | ||
``` | ||
|
||
### 5.3 JSON SCHEMA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This data structure is quite complicated and not easy for adopting future changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @huangsuyu
To clarify, the only addition to the protocol is the following field which needs to be added to the token by the issuer and is less than 120 bytes:
URI: "https://token.io/token_data.json" <--- 120byte string
The URI can be changed/updated at any time. This makes it very easy for adopting future changes.
The client (DEX/wallet/DAPP) then retrieves the json packet and displays the data. This data is off-chain and is very flexible.
As a minimum standard, all that needs to be added are the following fields:
- description
- icon
- website
Everything else is optional but enhances the DEX/Wallet/DAPP, and can be updated at any time.
--
I will also add that this is how ERC-721 Non-fungible Tokens have implemented meta-data since late 2017 and works well on Ethereum. DappBrowsers retrieve the NFT resources and display (CryptoKitties, OpenSea, TrustWallet etc)
--
To sum up:
On-chain: 120byte string
Off-chain queried by clients: json packet
Please let me know if you have more questions.
Actually these resources are rather centralized. What if one of those links is invalid or just changed. One purpose of these resources is to prevent scams. But if the token owner can decide which icon to use, it will be much easier for scammers. The alternative solution is we can share these resources in a repo. So explorers can share those resources. The resources can be audited so it can also prevent scams. |
Why not have the resource URI point to IPFS or something similar, so that it's content-addressable and thus not prone to that sort of scamming? |
hi @jpthor, I will suggest we give up BEP-5 here, as now there is a github.com/binance-chain/tokens-info repository to store all the information. Storing everything on the chain sounds an appealing idea, but there are benefits to store the information on github.
|
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
11 similar comments
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpthor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
outdate, archive it. |
***@***.***
El jue., dic. 1, 2022 19:44, Larry ***@***.***> escribió:
… outdate, archive it.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXVAMEVVGCC6NMGO5WBKMUTWLFH6BANCNFSM4HKQ5THA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Rubens1969 ***@***.***>
Sent: Friday, December 2, 2022 3:49:01 AM
To: bnb-chain/BEPs ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [bnb-chain/BEPs] BEP-5: Token Resources [IMPROVEMENT] (#5)
***@***.***
El jue., dic. 1, 2022 19:44, Larry ***@***.***> escribió:
outdate, archive it.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXVAMEVVGCC6NMGO5WBKMUTWLFH6BANCNFSM4HKQ5THA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXBZP27NYXN4O3XQGWP5OP3WLFIQ3ANCNFSM4HKQ5THA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This BEP describes an improvement to the BEP-2 Token standard to add resources for token management on the Binance Chain.
Token Resources are managed by a URI that is specified as part of an issued token on Binance Chain.