Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-5: Token Resources [IMPROVEMENT] #5

Closed
wants to merge 10 commits into from

Conversation

jpthor
Copy link

@jpthor jpthor commented May 3, 2019

This BEP describes an improvement to the BEP-2 Token standard to add resources for token management on the Binance Chain.

Token Resources are managed by a URI that is specified as part of an issued token on Binance Chain.

Initial commit
@jpthor jpthor changed the title Create BEP5.md BEP-5: Token Resources [IMPROVEMENT] May 3, 2019
jpthor and others added 3 commits May 3, 2019 14:07
}
```

### 5.3 JSON SCHEMA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data structure is quite complicated and not easy for adopting future changes.

Copy link
Author

@jpthor jpthor May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @huangsuyu

To clarify, the only addition to the protocol is the following field which needs to be added to the token by the issuer and is less than 120 bytes:

	URI: "https://token.io/token_data.json"   <--- 120byte string

The URI can be changed/updated at any time. This makes it very easy for adopting future changes.

The client (DEX/wallet/DAPP) then retrieves the json packet and displays the data. This data is off-chain and is very flexible.

As a minimum standard, all that needs to be added are the following fields:

  • description
  • icon
  • website

Everything else is optional but enhances the DEX/Wallet/DAPP, and can be updated at any time.

--

I will also add that this is how ERC-721 Non-fungible Tokens have implemented meta-data since late 2017 and works well on Ethereum. DappBrowsers retrieve the NFT resources and display (CryptoKitties, OpenSea, TrustWallet etc)

--

To sum up:

On-chain: 120byte string
Off-chain queried by clients: json packet

Please let me know if you have more questions.

@yutianwu
Copy link
Contributor

yutianwu commented May 7, 2019

Actually these resources are rather centralized. What if one of those links is invalid or just changed. One purpose of these resources is to prevent scams. But if the token owner can decide which icon to use, it will be much easier for scammers.

The alternative solution is we can share these resources in a repo. So explorers can share those resources. The resources can be audited so it can also prevent scams.

@hiddentao
Copy link

Why not have the resource URI point to IPFS or something similar, so that it's content-addressable and thus not prone to that sort of scamming?

@darren-liu
Copy link
Contributor

hi @jpthor,

I will suggest we give up BEP-5 here, as now there is a github.com/binance-chain/tokens-info repository to store all the information. Storing everything on the chain sounds an appealing idea, but there are benefits to store the information on github.

  1. much more friendly accessible via all the existing git and github toolings, to users, designer, and managers of all levels
  2. easy to change, explore and link, including all the history

@iakisme
Copy link

iakisme commented Aug 6, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

11 similar comments
@iakisme
Copy link

iakisme commented Aug 6, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 7, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 8, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 9, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 10, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 11, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 12, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 13, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 14, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 15, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iakisme
Copy link

iakisme commented Aug 16, 2021

@jpthor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brilliant-lx
Copy link
Contributor

outdate, archive it.

@Rubens1969
Copy link

Rubens1969 commented Dec 2, 2022 via email

@blaaauw
Copy link

blaaauw commented Dec 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants