Improved macOS and Apple Silicon support #3084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved handling of features unsupported on Apple Silicon: - Minimized code duplication when choosing and setting FP precision - Removed unsupported optimizers from the drop-down when running on Apple Silicon Disabled features unsupported for Apple Silicon: - Made floating point precision UI non-interactive when running on Apple Silicon Fixed bugs: - Fixed failure when training tries to resume after the previous crash and there are no necessary files in the training directory - Fixed UI issue when model type buttons are not displayed correctly when local/unrecognized model is selected - Fixed incorrect read of config setting for Dataset Preparation output directory Enabled UI for running on Apple Silicon with MPS backend - common_gui.local_device(): either accelerate.Accelerator().device or None; - common_gui.device_list(): make a list of supported devices for the current system [fallback_device="cpu", local_device() if not None]; - common_gui.default_device(): common_gui.local_device() or fallback_device="cpu"; - common_gui.torch_device(): either common_gui.local_device() if torch supports it or fallback_device="cpu"; - Changed device radio buttons to use common_gui.device_list() and common_gui.default_device() to replace hard-coded values; - Added Apple MPS check to setup_common.check_torch() to remove warning shown on Mac systems; - Deleted duplicate code validate_requirements.check_torch(); - Removed xformers from requirements_macos_arm64.txt since xFormers supports Nvidia only and causes warnings and errors when running on Macs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of features unsupported on Apple Silicon:
Disabled features unsupported for Apple Silicon:
Fixed bugs:
Enabled UI for running on Apple Silicon with MPS backend