Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sd3 flux.1 uv #3051

Open
wants to merge 8 commits into
base: sd3-flux.1
Choose a base branch
from
Open

Sd3 flux.1 uv #3051

wants to merge 8 commits into from

Conversation

bmaltais
Copy link
Owner

@bmaltais bmaltais commented Jan 17, 2025

I want to move to a faster and simpler execution of the GUI using the new python pip replacement uv: https://github.com/astral-sh/uv

Let me know how it work for you. I have tested it on windows 11 and WSL2 Ubuntu 22.04 and it work great. Let me know how it goes for you.

To test, make sure to delete the existing venv folder.

On windows:

git checkout sd3-flux.1-uv
./gui-uv.bat

No need to run the setup.bat anymore.

On linux:

git checkout sd3-flux.1-uv
.\gui-uv.sh

or if you don't have a desktop

git checkout sd3-flux.1-uv
.\gui-uv.sh --headless

Same deal, no need to run setup.sh

@FurkanGozukara
Copy link
Contributor

i may test later. @bmaltais do you have any plans of making gradio for @kohya-ss new trainer https://github.com/kohya-ss/musubi-tuner

or do you know anyone?

@bmaltais
Copy link
Owner Author

bmaltais commented Jan 17, 2025

Was not aware of it... Might be an opportunity to start fresh. Will look at it to see how much work it would be. It is pretty ugly... it required seperate script for caching, etc... this add a ton of complexity... and it does not support toml parameters like sd-scripts... another big issue from a security point of view for the GUI. Not liking it.

@bmaltais
Copy link
Owner Author

Don't think I have the time nor the interest to write a GUI for it. I think I will pass on this one.

@FurkanGozukara
Copy link
Contributor

Don't think I have the time nor the interest to write a GUI for it. I think I will pass on this one.

thanks i guess i will make something dirty :D

@kohya-ss
Copy link
Contributor

Thank you for your continuous efforts. I'm sorry for the chaotic implementation of sd-scripts.

I'm sure that the support for uv will be useful to users.

BTW, Although it lacks documentation, Musubi Tuner can also be configured in .toml. Just for your information.

@bmaltais
Copy link
Owner Author

@kohya-ss Thank you for letting me know about the toml. I might attempt to make a MVP implementation for it... Will see how it goes.

@bmaltais
Copy link
Owner Author

@kohya-ss @FurkanGozukara I will start work on the GUI in this new repo: https://github.com/bmaltais/musubi-tuner-gui

Anyone who want to contribute to the GUI code are welcome. I will make this one use uv: https://github.com/astral-sh/uv as the python package manager to facilitate cross platform use. Will aim to support Linux and Windows. Not sure about MacOS. Those interested to the MacOS support side are welcome to contribute code to ensure proper support.

@Chron-O-John
Copy link

Chron-O-John commented Jan 28, 2025

Hi,
first you mixed-up the slashes/backslashes for linux/windows in your post.

second: (and more important)
gui-uv.sh is missing the venv activation, like gui.sh does:

# Step into GUI local directory
cd "$SCRIPT_DIR" || exit 1

if [ -d "$SCRIPT_DIR/venv" ]; then
    source "$SCRIPT_DIR/venv/bin/activate" || exit 1
else
    echo "venv folder does not exist. Not activating..."
fi

I think it should be added.

@bmaltais
Copy link
Owner Author

bmaltais commented Jan 28, 2025

uv auto activate the venv via uv run, so no need to activate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants