Open
Description
I don't think you're allowed to do this:
GTPSA.jl/src/fastgtpsa/temptps.jl
Lines 132 to 138 in 29e2f83
I think this only works "by accident", e.g., I suppose it could break with any Julia release, if Base
decides to change its implementation regarding setindex!
for Array
.
It seems like type piracy, in some sense. Or perhaps it's function punning that might be confusing to users? Not sure TBH, but it definitely feels very bad.
There's another potential issue with the method signature, though an easily fixable one: it matches setindex!(::Array{Union{}}, ::TempTPS, ::Int)
, which is surely not intended. Fix: #136
Metadata
Metadata
Assignees
Labels
No labels