Issue-562 | Added code changes to update pod scheduling error message… #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s member state details
|
Plz add some details here about what you tested and an example of what the relevant status fields look like in one of the test cases. |
| @@ -619,6 +623,9 @@ func updateStateRollup( | |||
| // Count missing container as waiting, at this point. | |||
| if memberStatus.StateDetail.LastKnownContainerState == containerMissing { | |||
| cr.Status.MemberStateRollup.MembersWaiting = true | |||
| if memberStatus.StateDetail.SchedulingErrorMessage != nil { | |||
| cr.Status.MemberStateRollup.MembersNotScheduled = true | |||
There was a problem hiding this comment.
In the block of stuff at the beginning of this function we must also set MembersNotScheduled to false initially.
| @@ -0,0 +1,37 @@ | |||
| // Copyright 2019 Hewlett Packard Enterprise Development LP | |||
|
Just a couple of minor fixes noted above, then this will be ready to merge. |
|
Sorry I'm logged into my personal GitHub account rather than corporate. Lemme switch... |
|
OK this should make it more official. :-) Just a couple of minor fixes noted above, then this will be ready to merge. |
joel-bluedata
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details about code changes
#562
Testing
Created 5 member ubuntu cluster
Couple of pods' scheduling failed because of less resource availability in the k8s cluster.
Then untainted the master node so that some of the pods can be scheduled on master.
Change in kd node id 5 status - Configured And No Scheduling Error Message