Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle cases where notify does not need to be sent #289

Closed
joel-bluedata opened this issue Apr 6, 2020 · 2 comments
Closed

handle cases where notify does not need to be sent #289

joel-bluedata opened this issue Apr 6, 2020 · 2 comments
Labels
Priority: High Project: Cluster Reconcile beyond simple xlate of model to K8s spec Type: Bug

Comments

@joel-bluedata
Copy link
Member

joel-bluedata commented Apr 6, 2020

If a member is deleted before it ever got out of create pending state, we don't need to (and therefore don't) send a delnodes notification to ready nodes, although we do update their configmeta.

A fairly common way to trigger this: ask for more members than can be placed in the current cluster (because of resource limitations), then realize the problem and reduce the number of members.

In the new reconciliation process since PR #272, this process is broken. The kdcluster will never return to a stable configured state even when the pending members are removed.

We need to change syncMemberNotifies to go ahead and make sure that lastSetupGeneration is up-to-date for a ready member who has no notifies queued to send.

Kartik is already doing this in PR #283 since he's dealing with another instance where we have changes to reconcile but no notifies to send; it's the first little block added to members.go in that PR. I'm mentioning it here because it's something we need to fix regardless of when PR #283 goes in.

It looks like issue #273, which involves skipping notifies, would also need this.

@joel-bluedata joel-bluedata added Type: Bug Project: Cluster Reconcile beyond simple xlate of model to K8s spec labels Apr 6, 2020
@joel-bluedata joel-bluedata added this to the 0.5.0 milestone Apr 6, 2020
@joel-bluedata joel-bluedata self-assigned this Apr 6, 2020
@joel-bluedata
Copy link
Member Author

Might want to think about doing an 0.4.1 bugfix release.

joel-bluedata added a commit to joel-bluedata/kubedirector that referenced this issue Apr 7, 2020
joel-bluedata added a commit that referenced this issue Apr 8, 2020
fix issue #289 for an 0.4.1 bugfix release
@joel-bluedata joel-bluedata removed their assignment Apr 13, 2020
@joel-bluedata joel-bluedata removed this from the 0.5.0 milestone Apr 14, 2020
@joel-bluedata
Copy link
Member Author

Will fix this in a 0.4.1 release and then merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Project: Cluster Reconcile beyond simple xlate of model to K8s spec Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant