Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling rotation gesture #4

Closed
wants to merge 3 commits into from
Closed

Enabling rotation gesture #4

wants to merge 3 commits into from

Conversation

renancaraujo
Copy link
Member

No description provided.

@suhas4090
Copy link

when will the rotation and move image will be implemented

@suhas4090
Copy link

i am using files of
https://github.com/renancaraujo/photo_view/tree/4bf597fdee1e46fd3b4aab22159f73557948c4f9

where i modified some files to move image position as well.

the custom library RotateGestureDetector was very helpful. Thanks. 👍

@renancaraujo
Copy link
Member Author

I've opened a PR in flutter/flutter adding framework support for rotation gesture. I've opened as I wait for final disclosure of this question since I think that a GestureDetector is a huge responsibility to carry with Photo View as a lib.

In other words, this PR is a snapshot of how Photo View must behave when rotation becomes available in Flutter.

If you think your changes are a good addition, you can share here, that would be great.

@renancaraujo
Copy link
Member Author

Unfortunately, I'm not having time to update this branch anymore. Photo View will support rotation as soon as flutter does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants