Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HeroPhotoView class which is more suitable for using with Hero … #19

Closed
wants to merge 1 commit into from
Closed

Added HeroPhotoView class which is more suitable for using with Hero … #19

wants to merge 1 commit into from

Conversation

olive009
Copy link

This PR fixes issue #15

@renancaraujo
Copy link
Member

Thanks for your contribution, I will review this in the next few days. Kudos!

@renancaraujo renancaraujo mentioned this pull request Aug 18, 2018
Closed
@renancaraujo
Copy link
Member

Thanks for your contribution. After reviewing your code, I used the idea of storing imageInfo as a state at #22 and posted a possible solution to the hero bug in #15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olive009 @renancaraujo