Implement HeroProperties
#177
Conversation
Effective dart: PREFER relative paths when importing libraries within your own package’s lib directory. You can check it here: https://dart.dev/guides/language/effective-dart/usage#prefer-relative-paths-when-importing-libraries-within-your-own-packages-lib-directory
Please refer to #175.
| @@ -153,9 +154,6 @@ class PhotoViewGallery extends StatefulWidget { | |||
| /// Mirror to [PhotoView.enableRotation] | |||
| final bool enableRotation; | |||
|
|
|||
| /// Mirror to [PhotoView.transitionOnUserGestures] | |||
| final bool transitionOnUserGestures; | |||
|
|
|||
There was a problem hiding this comment.
Seems like this is a negative side effect of this PR. Previously, the user could define transitionOnUserGestures to all PhotoViewGallery pages, but now they must define it to each page. However, I think most people use PhotoViewGallery.builder(), so they won't need to define transitionOnUserGestures more than once, anyway.
There was a problem hiding this comment.
Yeah, not that bad, but since it is a breaking change, this is gonna require a major version, thanks.
| HeroAttributes get heroAttributes => widget.heroAttributes; | ||
|
|
||
| PhotoViewControllerDelegate get delegate => widget.delegate; | ||
|
|
There was a problem hiding this comment.
I also created those getters for Widget attributes that are used very often.
There was a problem hiding this comment.
Great! I've detecetd an memory leak here involving delegate, but for now this is going in.
| onTapUp: widget.onTapUp == null ? null : onTapUp, | ||
| onTapDown: widget.onTapDown == null ? null : onTapDown, | ||
| onTapUp: onTapUp, | ||
| onTapDown: onTapDown, |
There was a problem hiding this comment.
Just a tiny detail. Instead dealing with null callbacks here, I created null-aware function calls inside onTapUp() and onTapDown().
|
The tests are passing and the examples are running, so I have no idea why CI is failing. If you could point me out on how to solve this, I'd work on it. |
Dont worry, im about to change how we are integrating this. LGTM. |
Please refer to #175.