Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #1

Closed
ggabrovski opened this issue Jun 3, 2018 · 6 comments
Closed

Small improvements #1

ggabrovski opened this issue Jun 3, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@ggabrovski
Copy link

First I want to thank you for this widget, it will be very useful if you can add:

  • Remove the fixed black color background form _PhotoViewImageWrapperState line 185 or make it custom.
  • Now is possible to zoom out too far, it should let you—but then shrink back to the initial zoom size.
  • The same is true for zoom in, maybe it will be good if we can set the max value for scale.
@renancaraujo renancaraujo added the enhancement New feature or request label Jun 5, 2018
@renancaraujo
Copy link
Member

Those are really good suggestions, thanks.
I'm hoping to get into some extra options on the next days.

@renancaraujo
Copy link
Member

Thanks to #3 and recent commits, i think all of those suggestions are covered by now.
Thank you for pointing it out.

renancaraujo pushed a commit that referenced this issue Jan 5, 2019
FIX: transitionOnUserGestures value not used
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 29, 2019
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 29, 2019
FIX: transitionOnUserGestures value not used
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 30, 2019
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 30, 2019
FIX: transitionOnUserGestures value not used
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 30, 2019
CarSmallGuo pushed a commit to CarSmallGuo/photo_view that referenced this issue May 30, 2019
FIX: transitionOnUserGestures value not used
@dpedrinha
Copy link

I still see the back background. I'm using the PUB version.

@dpedrinha
Copy link

Hmm I just noticed you added a backgroundDecoration prop.
Would be nice to have it transparent by default though. Me and probably other people out there need transparent PNGs and this black background took me some time to figure out.
Great plugin by the way.

@renancaraujo
Copy link
Member

Probably there are already tons of people using PhotoView by now. I will avoid major layout chages like this default swap. It is pretty simple to customize it.
We can simplify docs this regard.

@dpedrinha
Copy link

Makes sense. It's good that you think this way.
Maybe keep it for a major update. A simple update warning should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants