Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom error to context #2197

Merged
merged 4 commits into from
Mar 12, 2025
Merged

feat: add custom error to context #2197

merged 4 commits into from
Mar 12, 2025
+56 −26

Conversation

rakita
Copy link
Member

@rakita rakita commented Mar 12, 2025

Worldcoin uses a custom error inside Inspector to mark the transaction as invalid. To facilitate this use case we added Custom(String) error.

klkvr
klkvr approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just nits

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2197 will not alter performance

Comparing rakita/custom_ctx_error (6843d1b) with main (73e6b83)

Summary

✅ 8 untouched benchmarks

@rakita rakita merged commit 628327c into main Mar 12, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakita @klkvr