Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement AccessListTr for Vec #2136

Merged
merged 2 commits into from
Mar 4, 2025
Merged

feat: implement AccessListTr for Vec #2136

merged 2 commits into from
Mar 4, 2025

Conversation

Wodann
Copy link
Contributor

@Wodann Wodann commented Mar 4, 2025 •
edited
Loading

Adds support for Vec<AccessListItem> to use AccessListTr.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #2136 will degrade performances by 2.21%

Comparing NomicFoundation:feat/vec-access-list (432feeb) with main (55a3e8f)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ precompile bench | ecrecover precompile 195.5 µs 199.9 µs -2.21%

@Wodann Wodann mentioned this pull request Mar 4, 2025
Open
10 tasks
rakita
rakita approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 4635828 into bluealloy:main Mar 4, 2025
26 of 28 checks passed
This was referenced Mar 4, 2025
Closed
Closed
@Wodann Wodann deleted the feat/vec-access-list branch March 4, 2025 17:21
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wodann @rakita