Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Inspector trait from EthHandler into standalone crate #2075

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 12, 2025

Closes: #2069

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #2075 will degrade performances by 2.68%

Comparing rakita/extract_inspector_from_revm (c195002) with main (3a4acd4)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
analysis 226.8 µs 220.1 µs +3.06%
transfer 96.4 µs 89.6 µs +7.6%
precompile bench | ecrecover precompile 192.7 µs 198 µs -2.68%

@rakita rakita marked this pull request as ready for review February 12, 2025 18:35
@rakita
Copy link
Member Author

rakita commented Feb 13, 2025

Bench not related

@rakita rakita merged commit dd63090 into main Feb 13, 2025
27 of 28 checks passed
@rakita rakita deleted the rakita/extract_inspector_from_revm branch February 16, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Untungle Inspector from .transact
1 participant