Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Aero 17 XE5 #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mpolishchuck
Copy link

@mpolishchuck mpolishchuck commented Oct 7, 2023

Hello.

Just wanted to add support for my laptop Aero 17 XE5.

Seems like everything what is implemented so for is working on this model too.

However, there are two things:

  1. Fn+F12 generates different code. I've added new constant for it.
  2. When Fn key is being pressed then keyboard generated Xf86TouchpadOff button event. I do no know if it happens on other models. If yes then this is out of scope. Otherwise this should be fixed here. Not sure what to do with this. (This is solved for Aero 17 XE5 explicitly, see my note in conversation about this PR)

@mpolishchuck
Copy link
Author

Updated PR to solve point 2 from my note above. However I'm still not sure if it happens on other models, so it will work only for Aero 17 XE5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant