Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Created auth interceptor for use with Angular's HttpClient #11

Merged
merged 5 commits into from
Nov 14, 2018

Conversation

Blackbaud-PaulCrowder
Copy link
Member

The implementation contains a workaround for passing additional context to the interceptor since Angualr doesn't currently support it. Here is an issue describing the problem: angular/angular#18155

The implementation contains a workaround for passing additional context to the interceptor since Angualr doesn't currently support it.  Here is an issue describing the problem: angular/angular#18155
@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      5    +3     
  Lines          47    103   +56     
  Branches       10     24   +14     
=====================================
+ Hits           47    103   +56
Impacted Files Coverage Δ
...ublic/modules/auth-http-client/auth-interceptor.ts 100% <100%> (ø)
...odules/auth-http-client/auth-interceptor-params.ts 100% <100%> (ø)
...pp/public/modules/auth-http-client/auth-options.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382e0f1...a2c8b1e. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works great; code looks great.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit c46e0fb into master Nov 14, 2018
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the auth-interceptor branch November 14, 2018 00:14
@Blackbaud-SteveBrush
Copy link
Member

@blackbaud-johnly We'll need a documentation task for this, please.

@blackbaud-johnly
Copy link
Contributor

Created https://github.com/blackbaud/skyux2/issues/2187 to document this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants