This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Update version of @skyux/i18n
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 53 53
Lines 1637 1642 +5
Branches 241 241
=====================================
+ Hits 1637 1642 +5
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Sep 24, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Blackbaud-BobbyEarl I reverted some changes I made to the
sky-pages-module-generator. I've tested this branch on skyux2 and a few internal SPAs.This solves two problems:
No provider for SkyAuthHttp!error.@skyux/i18nto fix another problem that only occurred during unit tests. See: Fixed linting errors skyux-i18n#11