Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Reverted Pact interaction type for backwards compatibility #446

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Jul 27, 2018

Resolves: blackbaud/skyux2#1852

The type will be added back in the new @skyux-sdk/pact library:
https://github.com/blackbaud/skyux-sdk-pact/blob/master/src/app/public/pact.service.ts#L45

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          73       73           
  Lines        1922     1922           
  Branches      304      304           
=======================================
  Hits         1909     1909           
  Misses         13       13
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 95.6% <100%> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/pact.service.ts 41.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9ca6e...2b41604. Read the comment docs.

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl merged commit 52433b1 into master Aug 2, 2018
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the fix-pact-service-type branch August 2, 2018 14:38
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants