This repository was archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Update skyAppLink to use optional excludeDefaults to getAll. #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=========================================
+ Coverage 99.3% 99.3% +<.01%
=========================================
Files 73 73
Lines 1867 1873 +6
Branches 293 294 +1
=========================================
+ Hits 1854 1860 +6
Misses 13 13
Continue to review full report at Codecov.
|
Let me know if this implementation is more inline what what you were thinking @Blackbaud-PaulCrowder. |
Blackbaud-PaulCrowder
suggested changes
May 2, 2018
runtime/params.ts
Outdated
return params; | ||
}; | ||
|
||
return this.getAllKeys() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion here would be to write a simple loop to build up the object. It'll cut down on both the amount of code written as well as the number of loops executed (1 vs. 2) and be more legible IMO.
const filteredParams: { [key: string]: string} = {};
this.getAllKeys().forEach(key => {
if (!excludeDefaults || this.params[key] !== this.defaultParamValues[key]) {
filteredParams[key] = this.params[key];
}
});
return filteredParams;
Blackbaud-PaulCrowder
approved these changes
May 2, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing blackbaud/skyux2#1650