Fixed query param issue skyAppLink #390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 99.25% 99.25% +<.01%
==========================================
Files 71 71
Lines 1750 1755 +5
Branches 284 285 +1
==========================================
+ Hits 1737 1742 +5
Misses 13 13
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
requested review from
Blackbaud-BobbyEarl and
Blackbaud-SteveBrush
| @@ -8,24 +8,34 @@ import { SkyAppConfig } from '../config'; | |||
| import { SkyAppLinkDirective } from './sky-app-link.directive'; | |||
|
|
|||
| @Component({ | |||
| template: `<a skyAppLink="test">Test</a>` | |||
| template: `<a skyAppLink='test'>Test</a>` | |||
There was a problem hiding this comment.
No functional difference, but any reason these are single quotes? Same question for line 16.
There was a problem hiding this comment.
There's no particular reason. It's probably just muscle memory typing things in a TS file vs. html. That particular line got changed because I copied a bit of code from the external link directive tests and when I massaged it to fit this context, that single quote change was all that was left.
I prefer the double quotes, so I've updated the PR to clean that up plus some other development remnants in the spec file for both tests.
* Fixed query param issue skyAppLink blackbaud/skyux2#1603 * Remove fdescribe * Code cleanup for tests
blackbaud/skyux2#1603