This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Added test + logic to shortcircuit test command #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-BobbyEarl
requested review from
Blackbaud-PaulCrowder and
Blackbaud-SteveBrush
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 99.25% 99.25% +<.01%
==========================================
Files 71 71
Lines 1743 1750 +7
Branches 283 284 +1
==========================================
+ Hits 1730 1737 +7
Misses 13 13
Continue to review full report at Codecov.
|
test/cli-test.spec.js
Outdated
| @@ -227,4 +227,16 @@ describe('cli test', () => { | |||
|
|
|||
| expect(process.exit).toHaveBeenCalledWith(0); | |||
| }); | |||
|
|
|||
| it('should not continue if no e2e spec files exist', () => { | |||
There was a problem hiding this comment.
Do you mean "no unit test spec"?
There was a problem hiding this comment.
Yep. Correcting now...
cli/test.js
Outdated
| @@ -46,6 +50,11 @@ function test(command, argv) { | |||
| process.exit(exitCode); | |||
| }; | |||
|
|
|||
| if (specsGlob.length === 0) { | |||
| logger.info('No spec files located. Stopping command from running.'); | |||
There was a problem hiding this comment.
I'd maybe change the wording to "No spec files located. Skipping test command."
There was a problem hiding this comment.
I copied this text verbatim from what's displayed today in skyux e2e. I'll update both to use your text, accounting for "test" vs "e2e" of course.
Blackbaud-SteveBrush
approved these changes
Mar 29, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
* Added test + logic to shortcircuit test command * Incorporated feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should shave off a couple minutes of builds, mainly for Stache sites that contain to unit tests.