Allow libraries to define their own locale files #379
Conversation
config/sky-pages/sky-pages.config.js
Outdated
| @@ -22,132 +22,137 @@ function readConfig(file) { | |||
| return fs.readJsonSync(file, 'utf8'); | |||
| } | |||
|
|
|||
| module.exports = { | |||
| /** | |||
There was a problem hiding this comment.
There are zero functional changes to this file; I simply adjusted the format so we can use a few of its methods (namely spaPath) via destructuring. (See my changes to common.webpack.config.js for an example.)
There was a problem hiding this comment.
Just want to say I appreciate you calling this out. It definitely helps when reviewing.
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 99.26% 99.29% +0.03%
==========================================
Files 72 73 +1
Lines 1766 1853 +87
Branches 287 292 +5
==========================================
+ Hits 1753 1840 +87
Misses 13 13
Continue to review full report at Codecov.
|
| @@ -1,24 +1,73 @@ | |||
| /*jshint jasmine: true, node: true */ | |||
| 'use strict'; | |||
|
|
|||
| const codegen = require('../utils/codegen-utils'); | |||
| const mock = require('mock-require'); | |||
There was a problem hiding this comment.
This spec file was affecting the state of other unit tests, so I mocked out its dependencies and made sure those dependencies' unit tests were covered 100%.
Blackbaud-SteveBrush
changed the title
Blackbaud-SteveBrush
changed the title
|
@Blackbaud-BobbyEarl This is ready for another look. |
|
Great job on this @Blackbaud-SteveBrush! Aside from the destructing we talked about offline the only other thing that stood out to me is the use of the |
|
@Blackbaud-BobbyEarl I've since removed the destructured method imports, and removed the |
Addresses: blackbaud/skyux2#1546
NOTE: I had to fix some unit tests that were reaching a bit too far into other files.