Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Added resources and host locale provider to runtime module #371

Merged
merged 6 commits into from
Mar 20, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Mar 13, 2018

This will allow libraries to pull in skyAppResources pipe.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Added app resources to runtime module Added resources and host locale provider to runtime module Mar 15, 2018
@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #371 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   99.25%   99.25%   -0.01%     
==========================================
  Files          72       71       -1     
  Lines        1739     1738       -1     
  Branches      282      282              
==========================================
- Hits         1726     1725       -1     
  Misses         13       13
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 94.75% <ø> (-0.03%) ⬇️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/sky-pages-module-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ee569...affa59c. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Added resources and host locale provider to runtime module [HOLD] Added resources and host locale provider to runtime module Mar 19, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Added resources and host locale provider to runtime module Added resources and host locale provider to runtime module Mar 19, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit da3fbf5 into master Mar 20, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the runtime-module-resources branch April 23, 2018 18:48
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants