This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Load omnibar outside Angular #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omnibar uses `setInterval()` to detect user activity, but running this inside Angular causes change detection to run every cycle. Loading omnibar outside Angular avoids this.
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 59 59
Lines 1371 1373 +2
Branches 209 210 +1
=====================================
+ Hits 1371 1373 +2
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnibar uses
setInterval()to detect user activity, but running thisinside Angular causes change detection to run every cycle. Loading
omnibar outside Angular avoids this.