This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Having runCommand return a boolean #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-BobbyEarl
requested review from
Blackbaud-PaulCrowder and
Blackbaud-SteveBrush
Blackbaud-PaulCrowder
suggested changes
Sep 21, 2017
test/index.spec.js
Outdated
| @@ -57,15 +57,18 @@ describe('@blackbaud/skyux-builder', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should handle unknown command', () => { | |||
| it('should return false unknown command', () => { | |||
There was a problem hiding this comment.
The name of this test should probably be "should return false for unknown command".
There was a problem hiding this comment.
"for" sure. :-) Updated.
There was a problem hiding this comment.
Forget the "for"? :)
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 58 58
Lines 1358 1358
Branches 205 205
=====================================
Hits 1358 1358
Continue to review full report at Codecov.
|
Blackbaud-PaulCrowder
approved these changes
Sep 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via blackbaud/skyux-cli#131,
skyux-cliwill become more informed regarding if a module "handled" the command passed viarunCommand. This PR satisfies that requirement.