Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Added --no-coverage flag to skyux watch #157

Merged
merged 6 commits into from
May 23, 2017

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented May 18, 2017

How to test:

  • Type skyux watch --no-coverage <-- instrument loader will not mangle the source files

Addresses issue #643

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #157   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         696    711   +15     
  Branches       85     89    +4     
=====================================
+ Hits          696    711   +15
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
config/karma/shared.karma.conf.js 100% <ø> (ø) ⬆️
index.js 100% <100%> (ø) ⬆️
cli/test.js 100% <100%> (ø) ⬆️
config/webpack/test.webpack.config.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f0e70...4f0d828. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link

Blackbaud-BobbyEarl commented May 19, 2017

A few questions:

Any thoughts on putting argv as the second argument to the getWebpackConfig() method?

Wondering if we could simplify it a bit so that --no-coverage flag is simply passed through? Then in getWebpackConfig you could always push the coverage rule, unless argv['no-coverage'] exists. Might be better than passing around the string versions of a boolean and changing what's the default in each method.

Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll still need to add documentation around this option as well.

@blackbaud-johnly
Copy link
Contributor

I created blackbaud/skyux2#723 to document this option. Thanks @Blackbaud-BobbyEarl

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 76952ee into master May 23, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the disable-coverage-watch branch May 23, 2017 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants