New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

! in comparison changed to != #190

Merged

bk138 merged 1 commit into bk138:master from pascal-niklaus:devel_parens_in_callback

Feb 25, 2024

Contributor

pascal-niklaus commented Feb 22, 2024

This refers to #188

  if(!gdk_device_get_device_type(device) == GDK_DEVICE_TYPE_MASTER ...)

was a bit unfortunate since this evaluates to TRUE when gdk_device_get_device_type returns values > 0, since GDK_DEVICE_TYPE_MASTER is 0.

Changed to the clearer form:

  if (gdk_device_get_device_type(device) != GDK_DEVICE_TYPE_MASTER ...)


          ! in comparison changed to !=

5bb8844

bk138 merged commit 2446a4f into bk138:master

1 check failed

Owner

bk138 commented Feb 25, 2024

@pascal-niklaus thanks! please prefix commit messages with the subsystem changed for future commits and make the messsage in the form, "when applied, this commit wil ..." as per https://github.com/bk138/gromit-mpx/blob/master/CONTRIBUTING.md :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet