Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4355] Add default email option to username generator dialog #6593

Conversation

igbominadeveloper
Copy link

@igbominadeveloper igbominadeveloper commented Oct 16, 2023

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

https://community.bitwarden.com/t/autofill-the-username-field-when-adding-a-new-login/59121

This PR extends the username generator component to allow users select their bitwarden email address as an option when generating a username. The closest feature to this existing is the plus address email but since not every service provider has full support for plus email address, it's expedient to have an option to create logins with the default email address of a user in bitwarden.

This also sets it as the first and default option when creating a username

Code changes

Screenshots

Screen.Recording.2023-10-16.at.14.46.50.mov

This PR would require an update to this document https://bitwarden.com/help/generator/#generate-a-username

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-4355

@bitwarden-bot bitwarden-bot changed the title Add default email option to username generator dialog [PM-4355] Add default email option to username generator dialog Oct 16, 2023
@igbominadeveloper igbominadeveloper force-pushed the @igbominadeveloper/add-default-email-to-username-generator branch from 71f7e04 to e220644 Compare October 16, 2023 23:22
@igbominadeveloper
Copy link
Author

Closing this as it encourages something that could pose a security risk. You can follow the conversation here - https://github.com/orgs/bitwarden/discussions/6592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants