-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-4355] Add default email option to username generator dialog #6593
Closed
igbominadeveloper
wants to merge
10
commits into
bitwarden:master
from
igbominadeveloper:@igbominadeveloper/add-default-email-to-username-generator
Closed
[PM-4355] Add default email option to username generator dialog #6593
igbominadeveloper
wants to merge
10
commits into
bitwarden:master
from
igbominadeveloper:@igbominadeveloper/add-default-email-to-username-generator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! We've added this to our internal Community PR board for review. |
This reverts commit d03a7ec.
71f7e04
to
e220644
Compare
Closing this as it encourages something that could pose a security risk. You can follow the conversation here - https://github.com/orgs/bitwarden/discussions/6592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
https://community.bitwarden.com/t/autofill-the-username-field-when-adding-a-new-login/59121
This PR extends the username generator component to allow users select their bitwarden email address as an option when generating a username. The closest feature to this existing is the plus address email but since not every service provider has full support for plus email address, it's expedient to have an option to create logins with the default email address of a user in bitwarden.
This also sets it as the first and default option when creating a username
Code changes
defaultemail
is handled in the conditions availableregenerate
button if the username type cannot be regeneratedScreenshots
Screen.Recording.2023-10-16.at.14.46.50.mov
This PR would require an update to this document https://bitwarden.com/help/generator/#generate-a-username
Before you submit