-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing crypto tests #5948
Fix failing crypto tests #5948
Conversation
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I also verified locally the Native Test Runner is working as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled branch and all test passed locally.
Type of change
Objective
Fixes failing crypto tests due to jestjs/jest#14379. This is accomplished through converting most of our usage of
ArrayBuffer
toUint8Array
, which works around the jest-environment-jsdom issue.Uint8Array
downcasts toArrayBuffer
without issues.Before you submit