Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL-554 update extension navigation text size #13549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielleflinn
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-554

📔 Objective

Added tw-text-sm class to navigation tabs

📸 Screenshots

See Chromatic
Uploading Screenshot 2025-02-24 at 4.03.33 PM.png…

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@danielleflinn danielleflinn requested a review from a team as a code owner February 25, 2025 00:09
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.82%. Comparing base (bc415d8) to head (a338f80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13549      +/-   ##
==========================================
- Coverage   35.83%   35.82%   -0.01%     
==========================================
  Files        3166     3166              
  Lines       93335    93335              
  Branches    16991    16991              
==========================================
- Hits        33442    33435       -7     
- Misses      57307    57314       +7     
  Partials     2586     2586              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details5756c71d-7586-4edf-8f07-7f0516b9a6e5

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant