-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17115] FIX - Truncate long links names in the vault filters #12887
Conversation
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12887 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 3175 3175
Lines 93626 93626
Branches 17034 17034
=======================================
Hits 33597 33597
Misses 57429 57429
Partials 2600 2600 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job, no security vulnerabilities found in this Pull Request |
|
@WOLFRIEND I have approved your code changes, great work! Thank you for your contribution. The next steps are that QA will be testing these changes, I will let you know the results from QA and if everything looks good then I will let you know which release your changes will be in. Thank you again. |
@WOLFRIEND your PR has been merged into main and is expected to be in our next release. Thank you again for your contribution and I hope to see more of your work in the future. 😄 |
🎟️ Tracking
N/A.
📔 Objective
Long links names on small screens resolution (desktop with small screens, tablets, etc.) are going beyond the "FILTERS" section borders in the Web Vault.
📸 Screenshots
Actual result:

Expected result:

⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes