Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17115] FIX - Truncate long links names in the vault filters #12887

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

WOLFRIEND
Copy link
Contributor

🎟️ Tracking

N/A.

📔 Objective

Long links names on small screens resolution (desktop with small screens, tablets, etc.) are going beyond the "FILTERS" section borders in the Web Vault.

📸 Screenshots

Actual result:

Expected result:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17115
Link: https://bitwarden.atlassian.net/browse/PM-17115

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title FIX - Truncate long links names in the vault filters [PM-17115] FIX - Truncate long links names in the vault filters Jan 15, 2025
@djsmith85 djsmith85 requested review from a team and nick-livefront January 29, 2025 20:23
Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.88%. Comparing base (e10b5af) to head (d6c7b65).
Report is 102 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12887   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files        3175     3175           
  Lines       93626    93626           
  Branches    17034    17034           
=======================================
  Hits        33597    33597           
  Misses      57429    57429           
  Partials     2600     2600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Logo
Checkmarx One – Scan Summary & Details21c5ec6a-f1c9-4800-b9ce-ff2af9b72c1d

Great job, no security vulnerabilities found in this Pull Request

@cd-bitwarden cd-bitwarden added the needs-qa Marks a PR as requiring QA approval label Mar 1, 2025
Copy link

sonarqubecloud bot commented Mar 3, 2025

@cd-bitwarden
Copy link
Contributor

@WOLFRIEND I have approved your code changes, great work! Thank you for your contribution. The next steps are that QA will be testing these changes, I will let you know the results from QA and if everything looks good then I will let you know which release your changes will be in. Thank you again.

@cd-bitwarden cd-bitwarden removed the needs-qa Marks a PR as requiring QA approval label Mar 13, 2025
@cd-bitwarden cd-bitwarden merged commit d0f337b into bitwarden:main Mar 13, 2025
54 of 62 checks passed
@cd-bitwarden
Copy link
Contributor

@WOLFRIEND your PR has been merged into main and is expected to be in our next release. Thank you again for your contribution and I hope to see more of your work in the future. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants