Variable Close-Icon, global configuration options #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macjohnny
reviewed
Apr 7, 2022
|
Code cleaned up + added global options via DI. Needed to increase lib version, hope that's ok? Otherwise you can just rewrite the global options applyment. Actually never done that before, but looks like a clean way imho. Looking forward to your opinion. |
macjohnny
reviewed
Apr 8, 2022
macjohnny
reviewed
Apr 8, 2022
|
Btw thanks for your effort, I think this is a great addition |
This was referenced Apr 11, 2022
|
Super, thank you! :) Ah, I see. You're now looping a string array. Thats ok. |
|
your features are released in https://github.com/bithost-gmbh/ngx-mat-select-search/releases/tag/4.1.0, thanks for your contribution! |
macjohnny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / npm Deploy would be awesome :)
Just a small fix, need it since I work only with svg based icons.