Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MultiSelectedValues are lost if previousValue has not been empty #279

Closed
broekema41 opened this issue Nov 13, 2020 · 4 comments · Fixed by #280
Closed

[BUG] MultiSelectedValues are lost if previousValue has not been empty #279

broekema41 opened this issue Nov 13, 2020 · 4 comments · Fixed by #280
Labels
bug Something isn't working
Milestone
3.1.3

Comments

@broekema41
Copy link
Contributor

Describe the bug
MultiSelectedValues are lost if previousValue has not been empty.

To Reproduce

The Germany Banks are no longer in the selection.

Expected behavior
Bank J (Italy) should be added to all the Germany banks

Screenshots
peek

Desktop (please complete the following information):

Additional context
Working on a pull request for your review.
@broekema41 broekema41 added the bug Something isn't working label Nov 13, 2020
@macjohnny
Copy link
Member

@broekema41 thanks for reporting. would you like to fix this?

broekema41 added a commit to broekema41/ngx-mat-select-search that referenced this issue Nov 15, 2020
@broekema41
Fix: multiselect now listening to value changes instead of search inp…
4611725 
…ut options (bithost-gmbh#279)
broekema41 added a commit to broekema41/ngx-mat-select-search that referenced this issue Nov 15, 2020
@broekema41
Fix: removing @input that i did not need (bithost-gmbh#279)
bcef125
@broekema41 broekema41 mentioned this issue Nov 15, 2020
Merged
@broekema41
Copy link
Contributor Author

hello @macjohnny,

Pull request is open for your review. If you have any question, remarks do not hesitate to ask.

kind regards,
Roland

macjohnny added a commit to broekema41/ngx-mat-select-search that referenced this issue Nov 16, 2020
@macjohnny
chore: refactor multiple handling
c06dce0 
bithost-gmbh#279
macjohnny added a commit that referenced this issue Nov 16, 2020
@broekema41 @macjohnny
Bugfix/multi select (#280)
4873efd 
* Fix: multiselect now listening to value changes instead of search input options (#279)

* Fix: removing @input that i did not need (#279)

* chore: refactor multiple handling

#279

Co-authored-by: roland broekema <rbroekema@ilionx.com>
Co-authored-by: Esteban Gehring <esteban.gehring@bithost.ch>
@macjohnny macjohnny added this to the 3.1.3 milestone Nov 16, 2020
@macjohnny
Copy link
Member

@broekema41 your fix was released with version 3.1.3

@aschemschat
Copy link

@macjohnny @broekema41
Hi :)
i'm just updating an app to angular 11 and bumbed the ngx-mat-select-search version from 3.0.3 to 3.1.3. With the new version I get null-references-failures, because this.matSelect.ngControl is null. This seems to be caused by the changes in mat-select-search.component.tss initMultipleHandling. The previous access was just this.matSelect.xxx and the commit changed it to this.matSelect.ngControl.xxx. I reverted back to 3.0.3 and that versions works with angular 11.
I haven't gotten the time yet to produce a minimal example to check, if i can reproduce the problem in a minimal environment though.

best regards

@macjohnny macjohnny reopened this Nov 17, 2020
@macjohnny macjohnny mentioned this issue Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.3
Development

Successfully merging a pull request may close this issue.

Bugfix/multi select broekema41/ngx-mat-select-search
3 participants
@aschemschat @broekema41 @macjohnny