Fix custom icon issue in BitNav's ChevronDownIcon (#10189)

[Cyrus-Sushiant]

This closes #10189

Summary by CodeRabbit

• Refactor
  • Updated the navigation icon behavior so that icons now adapt their visual style consistently based on their state, ensuring a more intuitive display when sections are expanded or collapsed.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the conditional logic in the BitNavChild component. The logic now uses the HasValue() method to check if the Nav.ChevronDownIcon property has a value. If true, it returns an empty string; if false, the code proceeds to check the isExpanded state, applying either "bit-nav-exp" or "bit-ico-r90" as a CSS class. This modification is applied in three instances within the same file.

Changes

File Path	Change Summary
src/BlazorUI/…/_BitNavChild.razor	Updated conditional logic for icon CSS classes: changed from using HasNoValue() to HasValue() for checking icon.

Sequence Diagram(s)

sequenceDiagram
    participant C as BitNavChild
    participant N as NavigationData
    participant R as RenderOutput

    C->>N: Evaluate ChevronDownIcon using HasValue()
    alt ChevronDownIcon has value
        N-->>C: true
        C->>R: Return empty CSS class
    else ChevronDownIcon has no value
        N-->>C: false
        C->>C: Check isExpanded state
        alt isExpanded true
            C->>R: Return "bit-nav-exp"
        else isExpanded false
            C->>R: Return "bit-ico-r90"
        end
    end

Loading

Poem

I’m a rabbit in the code,
Hopping through lines with a joyful mode.
Switching checks from “no value” to “has,”
Ensuring icons now beautifully pass.
With each condition clear and true, I code anew!
🐇💻

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f3280e and 42cd0f2.

📒 Files selected for processing (1)

• src/BlazorUI/Bit.BlazorUI/Components/Navs/Nav/_BitNavChild.razor (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (1)

src/BlazorUI/Bit.BlazorUI/Components/Navs/Nav/_BitNavChild.razor (1)

142-142: LGTM!

This implementation correctly applies the ternary conditional logic to handle the custom icon. When ChevronDownIcon has a value, no additional CSS class is applied; otherwise, it applies "bit-nav-exp" when expanded and "bit-ico-r90" when not expanded.