Problem with webpack (UglifyJS) and version bitcoinjs-lib@3.1.1 #959

Josema · 2017-12-11T16:43:08Z

I have a project using a Webpack boilerplate (https://github.com/Josema/preact-webpack-hmr) that has two environments. dev and prod. On dev, I don't have any issue because Webpack does not Uglify the code. But in prod I have this problem:

u {message: "Expected property "1" of type BigInteger, got n", __label: undefined, __property: 1, __value: n, __type: ƒ, …}message: "Expected property "1" of type BigInteger, got n"__label: undefined__property: 1__type: ƒ t(t)__value: n {0: 39560396, 1: 24254232, 2: 47726532, 3: 54351623, 4: 24134563, 5: 20729478, 6: 48965898, 7: 65576818, 8: 4252187, 9: 3018492, 10: 0, t: 10, s: 0}__valueTypeName: "n"stack: "Error: Expected property "1" of type BigInteger, got n↵    at d (http://localhost:8000/static/bundle/libs.js:13:92640)↵    at http://localhost:8000/static/bundle/libs.js:7:49765↵    at Array.every (<anonymous>)↵    at e (http://localhost:8000/static/bundle/libs.js:7:49707)↵    at i (http://localhost:8000/static/bundle/libs.js:7:48167)↵    at Object.i [as sign] (http://localhost:8000/static/bundle/libs.js:25:35134)↵    at n.sign (http://localhost:8000/static/bundle/libs.js:13:61402)↵    at http://localhost:8000/static/bundle/libs.js:25:55722↵    at Array.some (<anonymous>)↵    at d.sign (http://localhost:8000/static/bundle/libs.js:25:55590)"__proto__: Errorconstructor: ƒ f(e,t,r)__proto__: Object
(anonymous) @ main.js:1
Promise rejected (async)
value @ main.js:1
S @ libs.js:13

I know the error comes from bitcoinjs-lib because happen when I use the TransactionBuilder.sign() method.

Then, if I upgrade to 3.2.1 or above the problem of the code disappear. And I got this error when running Webpack/Uglify.

Output when using @3.1.1:

> webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details

Hash: f39c6260afc7aeb5b9fe
Version: webpack 3.4.1
Time: 43029ms
  Asset    Size  Chunks                    Chunk Names
main.js  248 kB       0  [emitted]         main
libs.js  578 kB       1  [emitted]  [big]  libs
  [14] ./src/api/crypto.js 5.64 kB {0} [built]
  [15] (webpack)/buildin/global.js 509 bytes {1} [built]
  [19] ./src/api/numbers.js 1.71 kB {0} [built]
  [23] ./src/api/Coins/ETH.js 6.13 kB {0} [built]
 [119] multi ./src/index.js 28 bytes {0} [built]
 [120] ./src/index.js + 88 modules 525 kB {0} [built]
 [201] (webpack)/buildin/module.js 517 bytes {1} [built]
    + 273 hidden modules

All good. Output when using @3.2.1 or above:

> webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details

Hash: cb0937ec69d6fb04ecff
Version: webpack 3.4.1
Time: 17002ms
  Asset     Size  Chunks                    Chunk Names
main.js   248 kB       0  [emitted]         main
libs.js  1.32 MB       1  [emitted]  [big]  libs
  [14] ./src/api/crypto.js 5.64 kB {0} [built]
  [15] (webpack)/buildin/global.js 509 bytes {1} [built]
  [19] ./src/api/numbers.js 1.71 kB {0} [built]
  [23] ./src/api/Coins/ETH.js 6.13 kB {0} [built]
 [124] multi ./src/index.js 28 bytes {0} [built]
 [125] ./src/index.js + 88 modules 525 kB {0} [built]
 [202] (webpack)/buildin/module.js 517 bytes {1} [built]
    + 274 hidden modules

ERROR in libs.js from UglifyJs
Unexpected token: name (ALPHABET) [libs.js:32162,4]

ERROR in libs.js from UglifyJs
Unexpected token: name (ALPHABET) [libs.js:32162,4]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! coinfy@1.0.0 build: `webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the coinfy@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/enzo/.npm/_logs/2017-12-11T16_28_14_841Z-debug.log

Notice that the size of libs.js change from 578 kB to 1.32 MB. I don't know how to fix this so any help would be really really appreciated.

I have created a repository with the minimal configuration to reproduce the same errors:
https://github.com/Josema/bitcoinjs-lib_error

The text was updated successfully, but these errors were encountered:

fanatid · 2017-12-11T16:50:15Z

bitcoinjs-lib start used https://github.com/bitcoinjs/bech32/ from 3.2.0
bech32 uses let, maybe you receive problem because this.
Can you try build bech32?

Josema · 2017-12-11T16:53:29Z

Sorry, what do you mean by building bech32. Whats the process for that?

fanatid · 2017-12-11T16:57:12Z

With trying building bech32 we will able determine is this issue related with bech32 or not.

Josema · 2017-12-11T17:02:46Z

But I don't know how to build bech32 standalone. I just use npm for everything.

junderw · 2017-12-11T22:51:10Z

npm -D install uglify-es-webpack-plugin

webpack.config.js

const UglifyEsPlugin = require('uglify-es-webpack-plugin');

module.exports = {
  // ・・・
  plugins: [
    new UglifyEsPlugin(),
  ],
  // ・・・
}

dcousens · 2017-12-11T23:09:57Z

@fanatid is let worth the trouble yet? Do we roll back bech32?

Josema · 2017-12-12T09:04:37Z

@junderw using uglify-es-webpack-plugin with @3.3.1 the problem with webpack disappear. But still the same problem in the code when using .sign()

I think the error comes from this line:

bitcoinjs-lib/src/ecdsa.js

Line 78 in fe0ad81

typeforce(types.tuple(types.Hash256bit, types.BigInt), arguments)

but I am not pretty sure because the code is very obfuscated.

I just updated the repository. The code of bitcoinjs-lib is very simple: https://github.com/Josema/bitcoinjs-lib_error/blob/master/src/index.js

This code works when npm run dev but fails when npm run build && npm run prod

afk11 · 2017-12-12T12:02:14Z

Our workaround was just not uglifying some parts of the code: https://github.com/blocktrail/blocktrail-sdk-nodejs/blob/1c39759def25bc52910583e3dda40db3e10a1fd4/Gruntfile.js#L161

Josema · 2017-12-12T12:44:06Z

Wow, that fixed the issue!

For webpack users just add the options inside of plugins UglifyEsPlugin

new UglifyEsPlugin({
    mangle: {
        reserved: [
            'Buffer',
            'BigInteger',
            'Point',
            'ECPubKey',
            'ECKey',
            'sha512_asm',
            'asm',
            'ECPair',
            'HDNode'
        ]
    }
})

Thank you @afk11. Thank you all too.

AndreasGassmann · 2018-10-11T11:24:31Z

Is there any way to get this to work with angular-cli projects? It seems that you cannot overwrite the uglify config, so the fix by @Josema doesn't work.

square-li · 2018-12-06T19:42:32Z

Is there any way to get this to work with angular-cli projects? It seems that you cannot overwrite the uglify config, so the fix by @Josema doesn't work.

In previous versions of angluar-cli, we can do ng eject to get the webpack configures. But now it is deprecated.

My solution for angular-cli is to use angular builder. After switching to the angular builder, you can config your own webpack settings and uglify-js settings.

Remind to put

{
"projects": {
 "architect": {
        "build": {
          "builder": "@angular-builders/custom-webpack:browser",
          "options": {
            "customWebpackConfig": {
              "path": "./extra-webpack.config.js",
              "replaceDuplicatePlugins": true,
              "mergeStrategies": {
                "optimization": "replace"
              }
            }
}}}}
}

at your angular.json file.

Also in extra-webpack.config.js, do it as @junderw did.
Otherwise, angular-cli default optimizing will still execute and break the bitcoin-js.

This problem takes me more than one day to figure out. Hope this would help.

#just-jeb/angular-builders#147

pdxwebdev · 2021-02-05T08:22:06Z

Those who are coming here from google, running into issues with bitcoinjs-lib and webpack 5. Try downgrading to webpack 4. Worked for me.

Some of the errors look like:
TypeError: Cannot read property ‘call’ of undefined

Hamidrezana · 2021-11-13T17:31:00Z

@Josema How can I apply it in react native project?

apollo0102 · 2023-02-27T15:29:29Z

I have a project using a Webpack boilerplate (https://github.com/Josema/preact-webpack-hmr) that has two environments. dev and prod. On dev, I don't have any issue because Webpack does not Uglify the code. But in prod I have this problem:

u {message: "Expected property "1" of type BigInteger, got n", __label: undefined, __property: 1, __value: n, __type: ƒ, …}message: "Expected property "1" of type BigInteger, got n"__label: undefined__property: 1__type: ƒ t(t)__value: n {0: 39560396, 1: 24254232, 2: 47726532, 3: 54351623, 4: 24134563, 5: 20729478, 6: 48965898, 7: 65576818, 8: 4252187, 9: 3018492, 10: 0, t: 10, s: 0}__valueTypeName: "n"stack: "Error: Expected property "1" of type BigInteger, got n↵    at d (http://localhost:8000/static/bundle/libs.js:13:92640)↵    at http://localhost:8000/static/bundle/libs.js:7:49765↵    at Array.every (<anonymous>)↵    at e (http://localhost:8000/static/bundle/libs.js:7:49707)↵    at i (http://localhost:8000/static/bundle/libs.js:7:48167)↵    at Object.i [as sign] (http://localhost:8000/static/bundle/libs.js:25:35134)↵    at n.sign (http://localhost:8000/static/bundle/libs.js:13:61402)↵    at http://localhost:8000/static/bundle/libs.js:25:55722↵    at Array.some (<anonymous>)↵    at d.sign (http://localhost:8000/static/bundle/libs.js:25:55590)"__proto__: Errorconstructor: ƒ f(e,t,r)__proto__: Object
(anonymous) @ main.js:1
Promise rejected (async)
value @ main.js:1
S @ libs.js:13

I know the error comes from bitcoinjs-lib because happen when I use the TransactionBuilder.sign() method.

Then, if I upgrade to 3.2.1 or above the problem of the code disappear. And I got this error when running Webpack/Uglify.

Output when using @3.1.1:

> webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details

Hash: f39c6260afc7aeb5b9fe
Version: webpack 3.4.1
Time: 43029ms
  Asset    Size  Chunks                    Chunk Names
main.js  248 kB       0  [emitted]         main
libs.js  578 kB       1  [emitted]  [big]  libs
  [14] ./src/api/crypto.js 5.64 kB {0} [built]
  [15] (webpack)/buildin/global.js 509 bytes {1} [built]
  [19] ./src/api/numbers.js 1.71 kB {0} [built]
  [23] ./src/api/Coins/ETH.js 6.13 kB {0} [built]
 [119] multi ./src/index.js 28 bytes {0} [built]
 [120] ./src/index.js + 88 modules 525 kB {0} [built]
 [201] (webpack)/buildin/module.js 517 bytes {1} [built]
    + 273 hidden modules

All good. Output when using @3.2.1 or above:

> webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details

Hash: cb0937ec69d6fb04ecff
Version: webpack 3.4.1
Time: 17002ms
  Asset     Size  Chunks                    Chunk Names
main.js   248 kB       0  [emitted]         main
libs.js  1.32 MB       1  [emitted]  [big]  libs
  [14] ./src/api/crypto.js 5.64 kB {0} [built]
  [15] (webpack)/buildin/global.js 509 bytes {1} [built]
  [19] ./src/api/numbers.js 1.71 kB {0} [built]
  [23] ./src/api/Coins/ETH.js 6.13 kB {0} [built]
 [124] multi ./src/index.js 28 bytes {0} [built]
 [125] ./src/index.js + 88 modules 525 kB {0} [built]
 [202] (webpack)/buildin/module.js 517 bytes {1} [built]
    + 274 hidden modules

ERROR in libs.js from UglifyJs
Unexpected token: name (ALPHABET) [libs.js:32162,4]

ERROR in libs.js from UglifyJs
Unexpected token: name (ALPHABET) [libs.js:32162,4]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! coinfy@1.0.0 build: `webpack --config=./webpack/production.js --optimize-minimize --progress --colors --display-error-details`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the coinfy@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/enzo/.npm/_logs/2017-12-11T16_28_14_841Z-debug.log

Notice that the size of libs.js change from 578 kB to 1.32 MB. I don't know how to fix this so any help would be really really appreciated.

I have created a repository with the minimal configuration to reproduce the same errors: https://github.com/Josema/bitcoinjs-lib_error

Hi sir.
I've also found same issue.
So I add uglify-es-webpack-plugin module. And create webpack.js and update it like yours.
But it has still same issues.

My project is a nextjs.
It works on dev mode, but it doesn't work in prod mode like "Expected property "1" of type BigInteger, got n" issues.
I need your help.

fanatid added the how to / question / docs label Dec 11, 2017

Josema added a commit to elevenyellow/coinfy that referenced this issue Dec 12, 2017

Fixed issue with webpack and bitcoinjs-lib bitcoinjs/bitcoinjs-lib#959

edcba5c

dcousens closed this as completed Dec 15, 2017

rptrainor mentioned this issue Dec 30, 2017

putFile() in production only returns UnCaught Error (in promise) message: "Expected property "1" of type BigInteger, got r" hirosystems/stacks.js#335

Closed

dabura667 mentioned this issue May 19, 2018

what's the reason of the wrong? #1075

Closed

macsj200 mentioned this issue Sep 21, 2018

Issue with deployed version titan-digital-exchange/offline-signing-tool#4

Closed

will123195 mentioned this issue Oct 9, 2018

Error: Expected Point, got s hotwallet/hotwallet#115

Closed

dschoeni mentioned this issue Oct 9, 2018

Production build optimization breaks code angular/angular-cli#11439

Closed

tatumio mentioned this issue Nov 20, 2019

TypeScript + Webpack minification error Bitcoin-com/bitbox-sdk#158

Closed

loxator mentioned this issue Jan 9, 2022

[Feature Request]: Option to not minify some parts of the code evanw/esbuild#1923

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem with webpack (UglifyJS) and version bitcoinjs-lib@3.1.1 #959

Problem with webpack (UglifyJS) and version bitcoinjs-lib@3.1.1 #959

Josema commented Dec 11, 2017 •

edited

Loading

fanatid commented Dec 11, 2017

Josema commented Dec 11, 2017

fanatid commented Dec 11, 2017

Josema commented Dec 11, 2017

junderw commented Dec 11, 2017

dcousens commented Dec 11, 2017

Josema commented Dec 12, 2017

afk11 commented Dec 12, 2017

Josema commented Dec 12, 2017

AndreasGassmann commented Oct 11, 2018

square-li commented Dec 6, 2018 •

edited

Loading

pdxwebdev commented Feb 5, 2021

Hamidrezana commented Nov 13, 2021

apollo0102 commented Feb 27, 2023

Problem with webpack (UglifyJS) and version bitcoinjs-lib@3.1.1 #959

Problem with webpack (UglifyJS) and version bitcoinjs-lib@3.1.1 #959

Comments

Josema commented Dec 11, 2017 • edited Loading

fanatid commented Dec 11, 2017

Josema commented Dec 11, 2017

fanatid commented Dec 11, 2017

Josema commented Dec 11, 2017

junderw commented Dec 11, 2017

dcousens commented Dec 11, 2017

Josema commented Dec 12, 2017

afk11 commented Dec 12, 2017

Josema commented Dec 12, 2017

AndreasGassmann commented Oct 11, 2018

square-li commented Dec 6, 2018 • edited Loading

pdxwebdev commented Feb 5, 2021

Hamidrezana commented Nov 13, 2021

apollo0102 commented Feb 27, 2023

Josema commented Dec 11, 2017 •

edited

Loading

square-li commented Dec 6, 2018 •

edited

Loading