bdk_wallet: Pin bdk_chain version to latest release
#1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
pin_chain_version_for_wallet
branch
from
6bf3f28 to
b3904a8
Compare
Remove the use of Cargo `path` ref for the `bdk_chain` and `bdk_file_store` dependencies. This is the first step to move `bdk_wallet` into a new workspace.
evanlinjin
force-pushed
the
pin_chain_version_for_wallet
branch
from
b3904a8 to
0c23410
Compare
4 tasks
LLFourn
approved these changes
Feb 28, 2025
notmandatory
added a commit
to notmandatory/bdk
that referenced
this pull request
Feb 28, 2025
…test release 0c23410 chore(wallet): Pin `bdk_chain` version to latest release (志宇) 7ce016d chore(examples): pin chain-src crates for wallet examples (志宇) 853dda4 ci: no-std requires hashbrown (志宇) Pull request description: ### Description As discussed here: https://discord.com/channels/753336465005608961/753336465005608965/1344807550217883688 Remove the use of Cargo `path` ref for the `bdk_chain` and `bdk_file_store` dependencies. This is the first step to move `bdk_wallet` into a new workspace. Also fixed CI failures as we were testing no-std without hashbrown. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: LLFourn: ACK 0c23410 notmandatory: ACK 0c23410 Tree-SHA512: 9c690ae153bc312f045a00ea82bf6772dc3393ee9835d44d0e1ae0570780a84de8cc537471b3c26b438eee49eb3262bd91e246d36e578ff8acd06609f0368dd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed here: https://discord.com/channels/753336465005608961/753336465005608965/1344807550217883688
Remove the use of Cargo
pathref for thebdk_chainandbdk_file_storedependencies. This is the first step to movebdk_walletinto a new workspace.Also fixed CI failures as we were testing no-std without hashbrown.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing