Introduce evicted-at/last-evicted timestamps
#1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
evicted_at
branch
5 times, most recently
from
6dc26c4 to
0fcc097
Compare
LagginTimes
force-pushed
the
evicted_at
branch
2 times, most recently
from
540a83f to
5107b3a
Compare
evanlinjin
force-pushed
the
evicted_at
branch
6 times, most recently
from
5718a3e to
07903a8
Compare
evanlinjin
changed the title
evicted-at/last-evicted timestamps
8 tasks
This is a set of evicted txs from the mempool.
The evicted-at and last-evicted timestamp informs the `TxGraph` when the transaction was last deemed as missing (evicted) from the mempool. The canonicalization algorithm is changed to disregard transactions with a last-evicted timestamp greater or equal to it's last-seen timestamp. The exception is when we have a canonical descendant due to rules of transitivity. Update rusqlite_impl to persist `last_evicted`. Also update docs: * Remove duplicate paragraphs about `ChangeSet`s. * Add "Canonicalization" section which expands on methods that require canonicalization and the associated data types used in the canonicalization algorithm.
The spk history returned from Electrum should have these txs present. Any missing tx will be considered evicted from the mempool.
* `TxGraph::try_list_expected_spk_txids` * `TxGraph::list_expected_spk_txids` * `IndexedTxGraph::try_list_expected_spk_txids` * `IndexedTxGraph::list_expected_spk_txids` Co-authored-by: valued mammal <valuedmammal@protonmail.com> Co-authored-by: Wei Chen <wzc110@gmail.com>
Co-authored-by: Wei Chen <wzc110@gmail.com>
Co-authored-by: Wei Chen <wzc110@gmail.com>
evanlinjin
force-pushed
the
evicted_at
branch
from
07903a8 to
9d6c795
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #1740.
Replaces #1765.
Replaces #1811.
Description
This PR allows the receiving structures (
bdk_chain,bdk_wallet) to detect and evict incoming transactions that are double spent (cancelled).We add a new field to
TxUpdate(TxUpdate::evicted_ats), which in turn, updates thelast_evictedtimestamps that are tracked/persisted byTxGraph. This is similar to howTxUpdate::seen_atsupdate thelast_seentimestamp inTxGraph. Transactions with alast_evictedtimestamp higher than theirlast_seentimestamp are considered evicted.SpkWithExpectedTxidsis introduced inSpkClientto track expectedTxids for eachspk. During a sync, if anyTxids fromSpkWithExpectedTxidsare not in the current history of anspkobtained from the chain source, thoseTxids are considered missing. Support forSpkWithExpectedTxidshas been added to bothbdk_electrumandbdk_esplorachain source crates.The canonicalization algorithm is updated to disregard transactions with a
last_evictedtimestamp greater than or equal to theirlast_seentimestamp, except in cases where transitivity rules apply.Notes to the reviewers
This PR does not fix #1740 for block-by-block chain source (such as
bdk_bitcoind_rpc). This work is done in a separate PR (#1857).Changelog notice
TxUpdate::evicted_atswhich tracks transactions that have been replaced and are no longer present in mempool.TxGraphto tracklast_evictedtimestamps. This is when a transaction is last marked as missing from the mempool.last_evictedtimestamp greater than or equal to it'slast_seentimestamp, except when a canonical descendant exists due to rules of transitivity.SpkWithExpectedTxidsinspk_clientwhich keeps track of expectedTxids for eachspk.bdk_electrumandbdk_esplorato understandSpkWithExpectedTxids.SyncRequestBuilder::expected_txids_of_spkmethod which adds an association betweentxids andspks.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: