Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cc pin to fix CI error #1829

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

LagginTimes
Copy link
Contributor

@LagginTimes LagginTimes commented Feb 10, 2025

Description

cc dependency was unpinned to fix a clash with cmake that was causing CI errors.

Changelog notice

  • Unpinned cc dependency.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@LagginTimes LagginTimes self-assigned this Feb 10, 2025
@LagginTimes LagginTimes added the ci label Feb 10, 2025
@LagginTimes LagginTimes changed the title ci: pin cmake for msrv ci: pin cmake to fix CI error Feb 10, 2025
@ValuedMammal
Copy link
Contributor

I wonder if we could instead just not pin cc?

@LagginTimes
Copy link
Contributor Author

cc = ^1.0.106 would require a MSRV above 1.63 (reference).

@ValuedMammal
Copy link
Contributor

I'm confused because it looks like cc has since reversed the decision to raise their MSRV, plus this CI failure https://github.com/bitcoindevkit/bdk/actions/runs/13237150987/job/36944325715 points to bdk_electrum as the cause which is supposed to be exempt from our MSRV of 1.63

@LagginTimes
Copy link
Contributor Author

LagginTimes commented Feb 11, 2025

Ah yes good catch, looks like cc 1.1.3 reduced the MSRV back to 1.63. I'll make the changes to this PR accordingly.

Edit:

points to bdk_electrum as the cause which is supposed to be exempt from our MSRV of 1.63

I believe this may be because the cargo updates from pin-msrv.sh run before the build and test commands that explicitly exclude bdk_electrum.

@LagginTimes LagginTimes changed the title ci: pin cmake to fix CI error ci: remove cc in to fix CI error Feb 11, 2025
@LagginTimes LagginTimes changed the title ci: remove cc in to fix CI error ci: remove cc pin to fix CI error Feb 11, 2025
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 979f9d1

@ValuedMammal ValuedMammal merged commit 7067da1 into bitcoindevkit:master Feb 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants