This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Build both x86_64 and aarch64 binaries when building bdk-jvm on macOS #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with my macOS Catalina v.10.15.7 , x86_64 |
notmandatory
approved these changes
May 21, 2022
There was a problem hiding this comment.
ACK b76bdfc
Thanks @waterst0ne for testing on your x86 mac, even though it doesn't work on an older mac I still think it's worth putting in this change since only people making mac releases need it and eventually with #38 this will be automated in CI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the Gradle plugin to ensure both
x86_64andaarch64versions ofbdk-jvmget built whenever one calls thebuildJvmLibcommand from macOS.Notes to the reviewers
This PR is still in draft mode because I need to test that the cross-compilation from an x86_64 mac works. In theory it should (it's one of the targets for the Rust compiler), but I have not tried it for myself yet.