-
Notifications
You must be signed in to change notification settings - Fork 13
Update bdk-ffi to 0.5 (with TxBuilder APIs) #40
Conversation
Looking at this right now. Should the submodule point to a tag on bdk-ffi? The |
@thunderbiscuit I was gonna pick that up and complete upgrading to 0.5 but happy to take help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree using testnet for the tests is not ideal for now (the wallet will drain rather quickly if we always run tests), but I do think it's good enough for now. I suggested one small change to the error message for the walletTxBuilderBroadcast
test. Otherwise everything worked well on my end.
I'm yet to upgrade to 0.5 tag which will add 2 new APIs for testing. |
Until we can get a CI regtest setup (see bitcoindevkit/bdk-ffi#241) I think the best approach is first run the JVM tests locally to get addresses to pre-fund the two testnet wallets for the |
After discussing with @thunderbiscuit I commented out the |
Do we need to add documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK a67b88a. @artfuldev was there anything else you were wanting to add? Yesterday I think you were saying you wanted to do a few more things. I don't want my ACK to mean "merge" if you're not ready.
Must be TESTNET to match BlockchainConfig.
Rebased. Working on updating the |
Description
Update bdk-ffi to bitcoindevkit/bdk-ffi#123 and add new TxBuilder tests.
Notes to the reviewers
I also fixed tests to use network and addresses for TESTNET to match BlockchainConfig.
The tests must be a bit hacky until we have a way to use REGTEST for our Kotlin tests.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md