Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject BIP-0047 (no progress in three years) #790

Closed
wants to merge 1 commit into from
Closed

Reject BIP-0047 (no progress in three years) #790

wants to merge 1 commit into from

Conversation

ysangkok
Copy link
Contributor

According to BIP-0002, if there has been no progress from Draft status in three years, anybody can request to have a BIP rejected.

@clarkmoody
Copy link
Contributor

BIP47 has been in production and heavy use by Samourai Wallet for years. There are probably other wallets that support it as well that I'm not aware of. I'm not sure what bearing that has on the BIP, but being adopted by some industry participants doesn't sound like a "rejected" BIP to me.

@ysangkok
Copy link
Contributor Author

Why hasn't @samouraiwallet submitted a PR for advancing the BIP to "Proposed" status?

@raymonddurk
Copy link

@SamouraiDev I thought you should be pinged as you have it pinned.

@SamouraiDev
Copy link
Contributor

Samourai Wallet implemented BIP47 and has since developed extensions for Segwit compatibility (P2SH and P2WPKH). Our PayNym offering is very popular as evidenced by the 22,129 users who have opted-in to sharing their stealth address and pseudonym on our directory PayNym.is. BIP47 will continue to provide a foundation for the services we provide. Merge this PR or not. This particular bureaucratic process is of no interest to us.

@xinbenlv
Copy link

xinbenlv commented Jul 4, 2019

If a standard has good adoption, I think it's worth effort making into the BIP or it will be a loss for both the proposal and the Bitcoin community....

@luke-jr
Copy link
Member

luke-jr commented Jul 23, 2019

@justusranvier needs to ACK a change to Proposed status.

@justusranvier
Copy link
Contributor

It would most likely improve the reputation of the payment code standard to not be associated with the repository in any way.

@luke-jr
Copy link
Member

luke-jr commented Jul 23, 2019

That makes no sense. Are you trolling?

Is this BIP still a draft, or can we move it to proposed (and maybe final)?

@SamouraiDev
Copy link
Contributor

It would most likely improve the reputation of the payment code standard to not be associated with the repository in any way.

Concept-ACK

@ysangkok
Copy link
Contributor Author

ysangkok commented Jul 25, 2019

@luke-jr Since the author doesn't want to work on the BIP, and the implementing parties don't seem to want to take it either, what can be done about this? You said it can't be "Proposed" if the author doesn't ACK, but it seems he isn't going to. So does that mean it gets stuck in Draft status forever?

@justusranvier
Copy link
Contributor

What does it mean for a protocol which can be freely implemented or not by any client without requiring permission from other participants in the network to be "Accepted" or "Rejected"?

The answer to that question is the difference between a real standardization process and a meaningless personal sandbox.

@luke-jr
Copy link
Member

luke-jr commented Jul 26, 2019

@justusranvier The question is whether this BIP is still a draft or not. If you intend to make further changes, then the implementations might then be incompatible, and the Final status void.

Perhaps it would make sense in some cases to say "too late, this BIP is in usage, so if you want to make changes, you'll need to make a new BIP for them" - but currently the BIP process doesn't authorise me (or anyone else) to simply make that call. We'd need to reassign the BIP to someone else first.

@ysangkok Anyone can volunteer to take over an abandoned BIP, it doesn't need to be an implementor.

@ysangkok
Copy link
Contributor Author

@justusranvier The BIP process considers the consensus of the community. Since this BIP was deemed to be "Unanimously Discourage[d] for implementation" (see BIP header), it provides value to the community to mark it as "Rejected", it clarifies the result of the discussion. Of course nobody can prevent anybody from implementing something, and nobody is stopping you from making your own standardization efforts (see SLIP).

You imply that it is a "meaningless personal sandbox", but if that were the case, how can it be that all high quality proposals are reflected in BIPs? I guess judging consensus will always be subjective, and I trust that @luke-jr can judge fairly what there is consensus for. It doesn't seem like there is consensus for this, and the fact that is has been implemented shouldn't force the community to accept the proposal.

I don't know how to counter your implication that this is not a "real standardization process", since that is so poorly defined. And I already explained to you why this isn't a "personal sandbox".

@justusranvier
Copy link
Contributor

@ysangkok This BIP and several others were vandalized with biased the personal opinions of a few Blockstream employees.

Since that time this repository should not be considered a reliable source of information for any use.

@luke-jr
Copy link
Member

luke-jr commented Jul 26, 2019

@ysangkok This BIP doesn't require consensus. Adoption by 2 or more pieces of software indicates a Final status.

@justusranvier That's just slander.

@ysangkok
Copy link
Contributor Author

Ok, so it seems like this can't be rejected, since it has prominent implementations. The headers says that it is "unanimously discouraged" for implementation, which is misleading since the people advocating the proposal have not commented. That is another issue, and I don't know if it can be fixed, but if it can, it would need an author's ACK, which seems unlikely. Since the only thing BIP-0002 rules allow me to do, is rejecting, and I can't do that, I will just close this, and it can be left in Draft status.

@ysangkok ysangkok closed this Feb 11, 2021
@ysangkok ysangkok deleted the bip-0047 branch February 11, 2021 17:45
@justusranvier
Copy link
Contributor

This PR should address all the concerns in this thread which can be addressed: #1068

@apemithrandir
Copy link

@ysangkok This BIP doesn't require consensus. Adoption by 2 or more pieces of software indicates a Final status.

@justusranvier That's just slander.

Sparrow Wallet, Samourai Wallet and Stack Wallet adopted this BIP. Does that mean the status can be changed to Final? Also does it mean the "Unanimously Discourage for implementation" comment will be rescinded?

@luke-jr
Copy link
Member

luke-jr commented Apr 8, 2023

Sparrow Wallet, Samourai Wallet and Stack Wallet adopted this BIP. Does that mean the status can be changed to Final?

Only with permission from the author, since it hasn't been formally proposed yet (still Draft).

Also does it mean the "Unanimously Discourage for implementation" comment will be rescinded?

That's just a summary of comments left on the comment wiki page. It's entirely independent of status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants