feat: Support HTTP basic authentication for schema registry connections #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdayz
approved these changes
May 21, 2023
|
Well done, thank you! |
|
Hi @birdayz, I can see this PR has been merged to master. Do you have plans to make a release including this change? Thanks for the nice work both of you, BTW 😊 |
|
thanks for the reminder. release 0.2.4 is now available. |
That was quick - thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new optional config section
schema-registry-credentials(including example). When set, a HTTP basic authentication header will be injected in calls to the schema registry.Also enables the schema registry support when using a consumer group.
I don't usually write Go, so apologies if I broke any conventions. Thanks for the excellent tool!